feat: API specs update for version latest#80
Conversation
Greptile SummaryThis PR extends the OAuth2 application consent model across all three OpenAPI 3 spec variants (client, console, server) with five new fields —
Confidence Score: 5/5Safe to merge — all changes are consistent across spec variants and the swagger2 removal is intentional per the commit message. The OAuth2 metadata fields are applied uniformly across client, console, and server specs in both request schemas and the response model. The database model updates in the console spec (type removal, reduced defaults, updated descriptions) align with the terminology shift reflected in the status and specification description changes. The swagger2 file deletions are explicitly described in the commit message as intentional cleanup. No files require special attention beyond what was already discussed in previous review threads. Important Files Changed
Reviews (2): Last reviewed commit: "(chore): remove swagger 2 specs for late..." | Re-trigger Greptile |
| @@ -105895,7 +105960,6 @@ | |||
| "$updatedAt", | |||
There was a problem hiding this comment.
Removal of
type from appwriteDatabase response model
The type field ("Database type: shared (serverless) or dedicated (always-on).") is removed from both the database-create request schema and the appwriteDatabase response model. Any existing console client that reads database.type to branch logic between shared and dedicated databases will silently receive undefined. The migration endpoint description still references "shared and dedicated types", so consumers navigating that flow may rely on this field. Worth confirming there is a migration guide or a deprecation notice for callers before this spec ships.
| "images": { | ||
| "type": "array", | ||
| "description": "Application image URLs shown to users during OAuth2 consent. Maximum of 100 images are allowed.", | ||
| "default": [], | ||
| "x-example": null, | ||
| "items": { | ||
| "type": "string" | ||
| } | ||
| }, |
There was a problem hiding this comment.
images items missing format: "url" annotation
The images array items are typed as plain "type": "string" without a "format": "url" annotation, while the two sibling scalar URL fields supportUrl and dataDeletionUrl in the same request schema both carry "format": "url". SDK generators and validators that respect the format keyword will enforce URL format for those scalars but not for individual image entries. The same inconsistency appears in the update-operation block (~line 4615), and is repeated in the equivalent positions in open-api3-latest-console.json and open-api3-latest-server.json.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Specs are generated and consumed as OpenAPI 3 only since appwrite/sdk-generator 2.0.0 and appwrite/appwrite#12565.
This PR contains API specification updates for version latest, regenerated through the OpenAPI 3 only pipeline (appwrite/sdk-generator 2.0.0 + appwrite/appwrite#12565).
It also removes the
swagger2-latest-*spec files: specs are generated and consumed as OpenAPI 3 only now. Swagger 2 files for older versions (1.8.x and below) are kept as historical artifacts.